[ https://issues.apache.org/jira/browse/HDFS-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039592#comment-14039592 ]
Hadoop QA commented on HDFS-6583: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12651743/HDFS-6583.000.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:red}-1 findbugs{color}. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7193//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/7193//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7193//console This message is automatically generated. > Remove clientNode in FileUnderConstructionFeature > ------------------------------------------------- > > Key: HDFS-6583 > URL: https://issues.apache.org/jira/browse/HDFS-6583 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Reporter: Haohui Mai > Assignee: Haohui Mai > Priority: Minor > Attachments: HDFS-6583.000.patch, HDFS-6583.001.patch > > > {{FileUnderConstructionFeature}} contains two fields {{clientMachine}} and > {{clientNode}}. {{clientNode}} keeps a reference of a {{DatanodeDescriptor}}. > The reference be recomputed by consulting {{DatanodeManager}}. > This jira proposes to remove {{clientNode}} in the > {{FileUnderConstructionFeature}} to simplify the code and to reduce overhead. -- This message was sent by Atlassian JIRA (v6.2#6252)