[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041065#comment-14041065 ]
Jing Zhao commented on HDFS-6562: --------------------------------- The new patch looks pretty good to me. +1 [~szetszwo], do you also want to take a look at the patch? > Refactor rename() in FSDirectory > -------------------------------- > > Key: HDFS-6562 > URL: https://issues.apache.org/jira/browse/HDFS-6562 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Haohui Mai > Assignee: Haohui Mai > Attachments: HDFS-6562.000.patch, HDFS-6562.001.patch, > HDFS-6562.002.patch, HDFS-6562.003.patch, HDFS-6562.004.patch > > > Currently there are two variants of {{rename()}} sitting in {{FSDirectory}}. > Both implementation shares quite a bit of common code. > This jira proposes to clean up these two variants and extract the common code. -- This message was sent by Atlassian JIRA (v6.2#6252)