[ https://issues.apache.org/jira/browse/HDFS-6556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042659#comment-14042659 ]
Hadoop QA commented on HDFS-6556: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12652235/refinedPermissions-HDFS-6556-2.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestCrcCorruption {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7226//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7226//console This message is automatically generated. > Refine XAttr permissions > ------------------------ > > Key: HDFS-6556 > URL: https://issues.apache.org/jira/browse/HDFS-6556 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.5.0 > Reporter: Yi Liu > Assignee: Uma Maheswara Rao G > Attachments: RefinedPermissions-HDFS-6556-1.patch, > RefinedPermissions-HDFS-6556.patch, refinedPermissions-HDFS-6556-2.patch > > > After discuss with Uma, we should refine setting permissions of {{user}} and > {{trusted}} namespace xattrs. > *1.* For {{user}} namespace xattrs, In HDFS-6374, says "setXAttr should > require the user to be the owner of the file or directory", we have a bit > misunderstanding. It actually is: > {quote} > The access permissions for user attributes are defined by the file permission > bits. only regular files and directories can have extended attributes. For > sticky directories, only the owner and privileged user can write attributes. > {quote} > We can refer to linux source code in > http://lxr.free-electrons.com/source/fs/xattr.c?v=2.6.35 > I also check in linux, it's controlled by the file permission bits for > regular files and directories (not sticky). > *2.* For {{trusted}} namespace, currently we require the user should be owner > and superuser. Actually superuser is enough. -- This message was sent by Atlassian JIRA (v6.2#6252)