[
https://issues.apache.org/jira/browse/HDFS-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046043#comment-14046043
]
Charles Lamb commented on HDFS-6391:
------------------------------------
LGTM, +1
Sorry about my nits, but I appreciate your indulgence. My intent with moving
the imports around was definitely not to have a wholesale reordering of FSD's
imports, but only to get your new ones in something of a proper ordering. +1
that we should not do a full-scale auto-format of imports and +1 that removing
unused imports is good since IDEs tend to whine about them.
There's still a whitespace change in HdfsConstants, but it's close enough to
the other change it probably doesn't matter in the scheme of things. There's
also another one in FSD#isUserVisible. I leave it to you to decide if you want
to remove it or not.
I like the new names for the xattrs.
Thanks for your work on this piece of the puzzle.
> Get the Key/IV from the NameNode for encrypted files in DFSClient
> -----------------------------------------------------------------
>
> Key: HDFS-6391
> URL: https://issues.apache.org/jira/browse/HDFS-6391
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode, security
> Reporter: Alejandro Abdelnur
> Assignee: Andrew Wang
> Attachments: HDFS-6391.1.patch, hdfs-6391.002.patch,
> hdfs-6391.003.patch
>
>
> When creating/opening and encrypted file, the DFSClient should get the
> encryption key material and the IV for the file in the create/open RPC call.
> HDFS admin users would never get key material/IV on encrypted files
> create/open.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
