[
https://issues.apache.org/jira/browse/HDFS-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14047893#comment-14047893
]
Jing Zhao commented on HDFS-6527:
---------------------------------
Copied from release vote mailing thread:
{code}
That's fine by me. Like I said, assuming that rc1 does indeed include the fix
in HDFS-6527, and not the revert, then rc1 should be functionally correct.
What's in branch-2.4.1 doesn't currently match what's in this RC, but if that
doesn't bother anyone else then I won't lose any sleep over it.
--
Aaron T. Myers
Software Engineer, Cloudera
> On Jun 27, 2014, at 3:04 PM, "Arun C. Murthy" <a...@hortonworks.com> wrote:
>
> Aaron,
>
> Since the amend was just to the test, I'll keep this RC as-is.
>
> I'll also comment on jira.
>
> thanks,
> Arun
{code}
In this way, I plan not to change branch-2.4.1 and leave it as it is. What do
you think [~atm] and [~acmurthy]?
> Edit log corruption due to defered INode removal
> ------------------------------------------------
>
> Key: HDFS-6527
> URL: https://issues.apache.org/jira/browse/HDFS-6527
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.4.0
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Priority: Blocker
> Fix For: 3.0.0, 2.5.0
>
> Attachments: HDFS-6527-addendum-test.patch,
> HDFS-6527.branch-2.4.patch, HDFS-6527.trunk.patch, HDFS-6527.v2.patch,
> HDFS-6527.v3.patch, HDFS-6527.v4.patch, HDFS-6527.v5.patch
>
>
> We have seen a SBN crashing with the following error:
> {panel}
> \[Edit log tailer\] ERROR namenode.FSEditLogLoader:
> Encountered exception on operation AddBlockOp
> [path=/xxx,
> penultimateBlock=NULL, lastBlock=blk_111_111, RpcClientId=,
> RpcCallId=-2]
> java.io.FileNotFoundException: File does not exist: /xxx
> {panel}
> This was caused by the deferred removal of deleted inodes from the inode map.
> Since getAdditionalBlock() acquires FSN read lock and then write lock, a
> deletion can happen in between. Because of deferred inode removal outside FSN
> write lock, getAdditionalBlock() can get the deleted inode from the inode map
> with FSN write lock held. This allow addition of a block to a deleted file.
> As a result, the edit log will contain OP_ADD, OP_DELETE, followed by
> OP_ADD_BLOCK. This cannot be replayed by NN, so NN doesn't start up or SBN
> crashes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
