[ 
https://issues.apache.org/jira/browse/HDFS-4265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14053820#comment-14053820
 ] 

Ivan Kelly commented on HDFS-4265:
----------------------------------

Change looks good, but you should add units to the conf key.
dfs.namenode.bookkeeperjournal.speculativeReadTimeout -> 
dfs.namenode.bookkeeperjournal.speculativeReadTimeoutMs

> BKJM doesn't take advantage of speculative reads
> ------------------------------------------------
>
>                 Key: HDFS-4265
>                 URL: https://issues.apache.org/jira/browse/HDFS-4265
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ha
>    Affects Versions: 2.2.0
>            Reporter: Ivan Kelly
>            Assignee: Rakesh R
>         Attachments: 001-HDFS-4265.patch, 002-HDFS-4265.patch
>
>
> BookKeeperEditLogInputStream reads entry at a time, so it doesn't take 
> advantage of the speculative read mechanism introduced by BOOKKEEPER-336.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to