[ https://issues.apache.org/jira/browse/HDFS-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056793#comment-14056793 ]
Hadoop QA commented on HDFS-6618: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12654834/HDFS-6618.simpler.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7309//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7309//console This message is automatically generated. > Remove deleted INodes from INodeMap right away > ---------------------------------------------- > > Key: HDFS-6618 > URL: https://issues.apache.org/jira/browse/HDFS-6618 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.5.0 > Reporter: Kihwal Lee > Assignee: Kihwal Lee > Priority: Blocker > Attachments: HDFS-6618.AbstractList.patch, > HDFS-6618.inodeRemover.patch, HDFS-6618.inodeRemover.v2.patch, > HDFS-6618.patch, HDFS-6618.simpler.patch > > > After HDFS-6527, we have not seen the edit log corruption for weeks on > multiple clusters until yesterday. Previously, we would see it within 30 > minutes on a cluster. > But the same condition was reproduced even with HDFS-6527. The only > explanation is that the RPC handler thread serving {{addBlock()}} was > accessing stale parent value. Although nulling out parent is done inside the > {{FSNamesystem}} and {{FSDirectory}} write lock, there is no memory barrier > because there is no "synchronized" block involved in the process. > I suggest making parent volatile. -- This message was sent by Atlassian JIRA (v6.2#6252)