[ https://issues.apache.org/jira/browse/HDFS-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056798#comment-14056798 ]
Aaron T. Myers commented on HDFS-6647: -------------------------------------- Oh, sorry, Kihwal - shouldn't this code also be checking to ensure that the file is under construction as well? {code} - if (file == null || !file.isUnderConstruction()) { + if (file == null || isFileDeleted(file)) { {code} i.e. I think it should be: {code} if (file == null || !file.isUnderConstruction() || isFileDeleted(file)) { {code} > Edit log corruption when pipeline recovery occurs for deleted file present in > snapshot > -------------------------------------------------------------------------------------- > > Key: HDFS-6647 > URL: https://issues.apache.org/jira/browse/HDFS-6647 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode, snapshots > Affects Versions: 2.4.1 > Reporter: Aaron T. Myers > Assignee: Kihwal Lee > Priority: Blocker > Attachments: HDFS-6647-failing-test.patch, HDFS-6647.patch > > > I've encountered a situation wherein an OP_UPDATE_BLOCKS can appear in the > edit log for a file after an OP_DELETE has previously been logged for that > file. Such an edit log sequence cannot then be successfully read by the > NameNode. > More details in the first comment. -- This message was sent by Atlassian JIRA (v6.2#6252)