[ 
https://issues.apache.org/jira/browse/HDFS-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062471#comment-14062471
 ] 

Hadoop QA commented on HDFS-6597:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12655785/HDFS-6597.04.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS
                  org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/7349//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7349//console

This message is automatically generated.

> Add a new option to NN upgrade to terminate the process after upgrade on NN 
> is completed
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-6597
>                 URL: https://issues.apache.org/jira/browse/HDFS-6597
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Danilo Vunjak
>         Attachments: HDFS-6597.04.patch, JIRA-HDFS-30.patch, 
> JIRA-HDFS-6597.02.patch, JIRA-HDFS-6597.03.patch, JIRA-HDFS-6597.patch
>
>
> Currently when namenode is started for upgrade (hadoop namenode -upgrade 
> command), after finishing upgrade of metadata, namenode starts working 
> normally and wait for datanodes to upgrade itself and connect to to NN. We 
> need to have option for upgrading only NN metadata, so after upgrade is 
> finished on NN, process should terminate.
> I have tested it by changing in file: hdfs.server.namenode.NameNode.java, 
> method: public static NameNode createNameNode(String argv[], Configuration 
> conf):
>  in switch added
>  case UPGRADE:
> case UPGRADE:
>       {
>         DefaultMetricsSystem.initialize("NameNode");
>           NameNode nameNode = new NameNode(conf);
>           if (startOpt.getForceUpgrade()) {
>                 terminate(0);
>                 return null;
>           }
>           
>           return nameNode;
>       }
> This did upgrade of metadata, closed process after finished, and later when 
> all services were started, upgrade of datanodes finished sucessfully and 
> system run .
> What I'm suggesting right now is to add new startup parameter "-force", so 
> namenode can be started like this "hadoop namenode -upgrade -force", so we 
> can indicate that we want to terminate process after upgrade metadata on NN 
> is finished. Old functionality should be preserved, so users can run "hadoop 
> namenode -upgrade" on same way and with same behaviour as it was previous.
>  Thanks,
>  Danilo



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to