[
https://issues.apache.org/jira/browse/HDFS-6690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063056#comment-14063056
]
Uma Maheswara Rao G commented on HDFS-6690:
-------------------------------------------
Thanks Andrew, for the Nice improvement.
nit:
I am with Charles on the map usage. Lets use Map for the type. Yes, it is
general practice.
{code}
+ private static final HashMap<String, String> internedNames =
+ Maps.newHashMap();
{code}
Looks good other than that.
> Deduplicate xattr names in memory
> ---------------------------------
>
> Key: HDFS-6690
> URL: https://issues.apache.org/jira/browse/HDFS-6690
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.5.0
> Reporter: Andrew Wang
> Assignee: Andrew Wang
> Attachments: hdfs-6690.001.patch
>
>
> When the same string is used repeatedly for an xattr name, we could
> potentially save some NN memory by deduplicating the strings.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
