[ 
https://issues.apache.org/jira/browse/HDFS-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066103#comment-14066103
 ] 

Hadoop QA commented on HDFS-6701:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12656428/HDFS-6701-v1.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
                  org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
                  org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
                  org.apache.hadoop.ipc.TestIPC
                  org.apache.hadoop.ipc.TestCallQueueManager
                  
org.apache.hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFS

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/7379//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7379//console

This message is automatically generated.

> Make seed optional in NetworkTopology#sortByDistance
> ----------------------------------------------------
>
>                 Key: HDFS-6701
>                 URL: https://issues.apache.org/jira/browse/HDFS-6701
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 2.5.0
>            Reporter: Ashwin Shankar
>         Attachments: HDFS-6701-v1.txt
>
>
> Currently seed in NetworkTopology#sortByDistance is set to the blockid which 
> causes the RNG to generate same pseudo random order for each block. If no 
> node local block location is present,this causes the same rack local replica 
> to be hit for a particular block.
> It'll be good to make the seed optional, so that one could turn it off if 
> they want block locations of a block to be randomized.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to