[ https://issues.apache.org/jira/browse/HDFS-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067968#comment-14067968 ]
Yongjun Zhang commented on HDFS-6588: ------------------------------------- The symlink tests failed three times in a row here, which indicates that something is wrong. I filed HDFS-6707, investigated and found root cause (irrelevant to the patch of HDFS-6588), posted patch there pending review. The other tests failed here appear to be flaky, but will try a run again once HDFS-6707 fix is committed. > Investigating removing getTrueCause method in Server.java > --------------------------------------------------------- > > Key: HDFS-6588 > URL: https://issues.apache.org/jira/browse/HDFS-6588 > Project: Hadoop HDFS > Issue Type: Bug > Components: security, webhdfs > Affects Versions: 2.5.0 > Reporter: Yongjun Zhang > Assignee: Yongjun Zhang > Attachments: HDFS-6588.001.patch, HDFS-6588.001.patch, > HDFS-6588.001.patch > > > When addressing Daryn Sharp's comment for HDFS-6475 quoted below: > {quote} > What I'm saying is I think the patch adds too much unnecessary code. Filing > an improvement to delete all but a few lines of the code changed in this > patch seems a bit odd. I think you just need to: > - Delete getTrueCause entirely instead of moving it elsewhere > - In saslProcess, just throw the exception instead of running it through > getTrueCause since it's not a "InvalidToken wrapping another exception" > anymore. > - Keep your 3-line change to unwrap SecurityException in toResponse > {quote} > There are multiple test failures, after making the suggested changes, Filing > this jira to dedicate to the investigation of removing getTrueCause method. > More detail will be put in the first comment. -- This message was sent by Atlassian JIRA (v6.2#6252)