[
https://issues.apache.org/jira/browse/HDFS-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14075029#comment-14075029
]
Colin Patrick McCabe commented on HDFS-6755:
--------------------------------------------
No new tests are needed, since this is just a one-line change moving a
Thread.sleep in an error case. Committing. Thanks, Mit.
> There is an unnecessary sleep in the code path where DFSOutputStream#close
> gives up its attempt to contact the namenode
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: HDFS-6755
> URL: https://issues.apache.org/jira/browse/HDFS-6755
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Mit Desai
> Assignee: Mit Desai
> Attachments: HDFS-6755.patch
>
>
> DFSOutputStream#close has a loop where it tries to contact the NameNode, to
> call {{complete}} on the file which is open-for-write. This loop includes a
> sleep which increases exponentially (exponential backoff). It makes sense to
> sleep before re-contacting the NameNode, but the code also sleeps even in the
> case where it has already decided to give up and throw an exception back to
> the user. It should not sleep after it has already decided to give up, since
> there's no point.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
