[
https://issues.apache.org/jira/browse/HDFS-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079987#comment-14079987
]
Jing Zhao commented on HDFS-6757:
---------------------------------
bq. It might not be sufficient as previous implementation of snapshot might
replace an inode with its subclass
With INode features we now no longer have INode replacement (exception for
INodeReference which is out of picture in this jira), thus I think it's fine to
use INode in the lease map. However, in the meanwhile, I'm not sure if this
will increase the possibility of memory leak due to failing to update the lease
map (maybe because of buggy code).
bq. In serialization's special handling of UC snapshot files
Actually this part of code (I guess you mean the special handling in
{{saveFilesUnderConstruction}}) is no longer called by the normal code path
after we use Protobuf for fsimage (only called by {{saveLegacyOIVImage}}).
Initially this part of code is a temporary solution for HDFS-5428.
> Simplify lease manager with INodeID
> -----------------------------------
>
> Key: HDFS-6757
> URL: https://issues.apache.org/jira/browse/HDFS-6757
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-6757.000.patch, HDFS-6757.001.patch,
> HDFS-6757.002.patch, HDFS-6757.003.patch, HDFS-6757.004.patch
>
>
> Currently the lease manager records leases based on path instead of inode
> ids. Therefore, the lease manager needs to carefully keep track of the path
> of active leases during renames and deletes. This can be a non-trivial task.
> This jira proposes to simplify the logic by tracking leases using inodeids
> instead of paths.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
