[ https://issues.apache.org/jira/browse/HDFS-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081571#comment-14081571 ]
Hadoop QA commented on HDFS-6796: --------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12658967/HDFS-6796.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/7513//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/7513//console This message is automatically generated. > Improving the argument check during balancer command line parsing > ----------------------------------------------------------------- > > Key: HDFS-6796 > URL: https://issues.apache.org/jira/browse/HDFS-6796 > Project: Hadoop HDFS > Issue Type: Bug > Components: balancer > Affects Versions: 2.4.1 > Reporter: Benoy Antony > Assignee: Benoy Antony > Attachments: HDFS-6796.patch > > > Currently balancer CLI parser simply checks if the total number of arguments > is greater than 2 inside the loop. Since the check does not include any loop > variables, it is not a proper check when there more than 2 arguments. -- This message was sent by Atlassian JIRA (v6.2#6252)