[ 
https://issues.apache.org/jira/browse/HDFS-6917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14109671#comment-14109671
 ] 

Colin Patrick McCabe commented on HDFS-6917:
--------------------------------------------

bq. Please put the debug command in sorted order in the case statement.

OK.

bq. Is there any real benefit in hiding the debug option from usage? If you 
don't want users to find it easily, probably better to not have it in the hdfs 
script at all and only call it via the full class. (There are lots of these in 
Hadoop already).

In a debugging scenario, it's really tedious to have to do all that typing... 
typing out full class names on an ssh connection that feels like it's over a 
14.4 baud modem isn't fun.  I can change this if people feel very strongly, but 
I'd prefer to have it accessible via 'hdfs debug' if possible...

bq. [~yzhangal]: I did not see Allen's latest comment when I made my previous. 
Maybe we should make the "recoverLease" command a privileged one only 
accessible by admin?

The permission checking happens on the NameNode, so we shouldn't have to do it 
in the client.

bq. can we add brief description about the individual command about what they 
do in addition to their arguments, in the above help message?

You can get that by doing {{hdfs debug help verify}}.  I thought this was 
consistent with how the other commands work (you get detailed help by doing 
help <command>)... does it feel consistent?

> Add an hdfs debug command to validate blocks, call recoverlease, etc.
> ---------------------------------------------------------------------
>
>                 Key: HDFS-6917
>                 URL: https://issues.apache.org/jira/browse/HDFS-6917
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.6.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-6917.001.patch
>
>
> HDFS should have a debug command which could validate HDFS block files, call 
> recoverLease, and have some other functionality.  These commands would be 
> purely for debugging and would appear under a separate command hierarchy 
> inside the hdfs command.  There would be no guarantee of API stability for 
> these commands and the debug submenu would not be listed by just typing the 
> "hdfs" command.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to