[ https://issues.apache.org/jira/browse/HDFS-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111612#comment-14111612 ]
Jing Zhao commented on HDFS-6920: --------------------------------- The patch looks good to me. +1 Can we also have a unit test for this? > Archival Storage: check the storage type of delNodeHintStorage when deleting > a replica > -------------------------------------------------------------------------------------- > > Key: HDFS-6920 > URL: https://issues.apache.org/jira/browse/HDFS-6920 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Attachments: h6920_20140823.patch > > > in BlockManager.chooseExcessReplicates, it does not check the storage type of > delNodeHintStorage. Therefore, delNodeHintStorage could possibly be chosen > even if its storage type is not an excess storage type. -- This message was sent by Atlassian JIRA (v6.2#6252)