[ 
https://issues.apache.org/jira/browse/HDFS-6843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115629#comment-14115629
 ] 

Andrew Wang commented on HDFS-6843:
-----------------------------------

If we're going to start requiring this, it's something that should be decided 
on common-dev / hdfs-dev, not unilaterally on this JIRA. As I stated above, I 
have the opposite view about requiring this in the main patch. I want to make 
it as easy as possible for external people to contribute code, and it's 
definitely more work to have to understand the spec and contract tests, update 
the site, build it, check it, add a new test, and run the contract tests.

Steve, you're also the person best equipped to review these changes anyway. 
Additionally, if you're interested in making them yourself, I'm happy to review 
too (as I've demonstrated previously).

For all these reasons, this feels like precisely the kind of thing that should 
go into a follow-on JIRA.

Let me also stress also that I helped review the contract tests in the first 
place because I think they're important and valuable, but again, I don't think 
that their introduction should mean an additional prerequisite for check-in.

> Create FSDataInputStream & FSDataOutputStream isEncrypted() method
> ------------------------------------------------------------------
>
>                 Key: HDFS-6843
>                 URL: https://issues.apache.org/jira/browse/HDFS-6843
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode, security
>    Affects Versions: 3.0.0
>            Reporter: Charles Lamb
>            Assignee: Charles Lamb
>         Attachments: HDFS-6843.001.patch, HDFS-6843.002.patch
>
>
> FileStatus should have a 'boolean isEncrypted()' method. (it was in the 
> context of discussing with AndreW about FileStatus being a Writable).
> Having this method would allow MR JobSubmitter do the following:
> -----
> BOOLEAN intermediateEncryption = false
> IF jobconf.contains("mr.intermidate.encryption") THEN
>   intermediateEncryption = jobConf.getBoolean("mr.intermidate.encryption")
> ELSE
>   IF (I/O)Format INSTANCEOF File(I/O)Format THEN
>     intermediateEncryption = ANY File(I/O)Format HAS a Path with status 
> isEncrypted()==TRUE
>   FI
>   jobConf.setBoolean("mr.intermidate.encryption", intermediateEncryption)
> FI



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to