[ 
https://issues.apache.org/jira/browse/HDFS-6959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119033#comment-14119033
 ] 

Colin Patrick McCabe commented on HDFS-6959:
--------------------------------------------

bq. In that case, would you please take a look at rev 001 instead? the change 
there is restricted to HDFS. Thanks

OK, reviewing v1.

bq. +  private String home_dir_base = 
DFSConfigKeys.DFS_USER_HOME_BASE_DIR_DEFAULT;

Should be final

{code}
+<property>
+  <name>dfs.user.home.base.dir</name>
+  <value>/user</value>
+  <description>Base directory of user home.</description>
+</property>
{code}

This description is a bit terse.  Maybe something like: the directory to 
prepend to the user name to get the user's home directory

looks good aside from that

> make user home directory customizable
> -------------------------------------
>
>                 Key: HDFS-6959
>                 URL: https://issues.apache.org/jira/browse/HDFS-6959
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 2.2.0
>            Reporter: Kevin Odell
>            Assignee: Yongjun Zhang
>            Priority: Minor
>         Attachments: HADOOP-10334.001.patch, HADOOP-10334.002.patch, 
> HADOOP-10334.002.patch
>
>
> The path is currently hardcoded:
> public Path getHomeDirectory() {
>     return makeQualified(new Path("/user/" + dfs.ugi.getShortUserName()));
>   }
> It would be nice to have that as a customizable value.  
> Thank you



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to