[ https://issues.apache.org/jira/browse/HDFS-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14123808#comment-14123808 ]
Aaron T. Myers commented on HDFS-6940: -------------------------------------- bq. If you write an application, which depends on HDFS (or any other system), whether you subclass or encapsulate anything from HDFS you can break that application by making changes to HDFS. E.g. a change in getBlockLocations() can break Yarn or HBase. Same here. Sure, but by creating a plugin interface or something of that ilk we can precisely define the contract, both for implementers of the interface and maintainers of the main system. By subclassing, you're making it more fragile. Anyway, I'm fine if you want to proceed with this direction, but please only commit this to the branch, not to trunk. No reason this change needs to be on trunk instead of the branch for you to be able to make progress. > Initial refactoring to allow ConsensusNode implementation > --------------------------------------------------------- > > Key: HDFS-6940 > URL: https://issues.apache.org/jira/browse/HDFS-6940 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Affects Versions: 3.0.0 > Reporter: Konstantin Shvachko > Assignee: Konstantin Shvachko > Attachments: HDFS-6940.patch > > > Minor refactoring of FSNamesystem to open private methods that are needed for > CNode implementation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)