[
https://issues.apache.org/jira/browse/HDFS-6940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125126#comment-14125126
]
Suresh Srinivas edited comment on HDFS-6940 at 9/8/14 2:43 PM:
---------------------------------------------------------------
[~atm] had specifically asked not to commit this to trunk. Why is this
committed to trunk and branch-2 without any discussion? I agree with him that
we should not be making methods public or protected, due to the burden of
maintaining this contract. You mentioned two backward incompatible changes (I
would like to know what they are). But there are numerous others that are never
detected because it is taken care of by the committers in the project. Lets not
lose sight of that. We have also had difficulty removing other dead code due to
vetoes, such as BackupNode. So I want to be careful before committing code
without a decision on consensus node. Without addressing the comments from
[~atm] who has been participating in this discussion, this patch should not
have been committed to trunk.
[~cos], please be respectful. One thing that I had held out making comment on
is, your committership was based on the work done in fault injection related
work done in Hadoop. I believe you have not contributed enough to the other
parts of the system that this patch is touching. One of the honor rule is, a
committer refrains from voting +1 on a patch related to the areas that he has
not contributed to. But I have seen in many of the jiras this is not followed
by you including this one.
I am -1 on this patch going into trunk and branch-2. Lets do this in the
feature branch. This is not a big enough refactor that makes merges difficult.
I think we should revert this change.
I also would like to hear other committers to comment on this issue and give
their thoughts.
was (Author: sureshms):
[~atm] had specifically asked not to commit this to trunk. Why is this
committed to trunk and branch-2 without any discussion? I agree with him that
we should not be making methods public or protected due to the burden of
maintaining this contract. You mentioned two backward incompatible changes (I
would like to know what they are). But there are numerous others that are never
detected because it is taken care of by the committers in the project. Lets not
lose sight of that. We have also had difficulty removing other dead code due to
vetoes such as BackupNode. So I want to be careful before committing code
without a decision on the content that this refactoring is being done for
should even be in HDFS. Without addressing the comments from [~atm] who has
been participating in this discussion, this patch should not have been
committed to trunk.
[~cos], please be respectful. One thing that I had held out making comment on
is, your committership was based on the work done in fault injection related
work done in Hadoop. I believe you have not contributed enough to the other
parts of the system that this patch is touching. One of the honor rule is, a
committer refrains from voting +1 on a patch related to the areas that he has
not contributed to. But I have seen in many of the jiras this is not followed
by you including this one.
I am -1 on this patch going into trunk and branch-2. Lets do this in the
feature branch. This is not a big enough refactor that makes merges difficult.
I think we should revert this change.q
I also would like to hear other committers to comment on this issue and give
their thoughts.
> Initial refactoring to allow ConsensusNode implementation
> ---------------------------------------------------------
>
> Key: HDFS-6940
> URL: https://issues.apache.org/jira/browse/HDFS-6940
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Affects Versions: 2.0.6-alpha, 2.5.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 2.6.0
>
> Attachments: HDFS-6940.patch
>
>
> Minor refactoring of FSNamesystem to open private methods that are needed for
> CNode implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
