[ https://issues.apache.org/jira/browse/HDFS-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132981#comment-14132981 ]
Gera Shegalov commented on HDFS-6888: ------------------------------------- Thanks, [~airbots] for updating the patch. +1 (non-binding) Two nits: debugCmdSet can be declared as a general Set {code} private Set<String> debugCmdSet = new HashSet<String>(); {code} Its initialization can be more brief: {code} debugCmdSet.addAll(Arrays.asList(conf.getTrimmedStrings( DFSConfigKeys.DFS_AUDIT_LOG_DEBUG_CMDLIST))); {code} > Remove audit logging of getFIleInfo() > ------------------------------------- > > Key: HDFS-6888 > URL: https://issues.apache.org/jira/browse/HDFS-6888 > Project: Hadoop HDFS > Issue Type: Bug > Affects Versions: 2.5.0 > Reporter: Kihwal Lee > Assignee: Chen He > Labels: log > Attachments: HDFS-6888-2.patch, HDFS-6888-3.patch, HDFS-6888.patch > > > The audit logging of getFileInfo() was added in HDFS-3733. Since this is a > one of the most called method, users have noticed that audit log is now > filled with this. Since we now have HTTP request logging, this seems > unnecessary. -- This message was sent by Atlassian JIRA (v6.3.4#6332)