[ 
https://issues.apache.org/jira/browse/HDFS-6912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133635#comment-14133635
 ] 

Andrew Wang commented on HDFS-6912:
-----------------------------------

+1 LGTM, thanks Colin

> SharedFileDescriptorFactory should not allocate sparse files
> ------------------------------------------------------------
>
>                 Key: HDFS-6912
>                 URL: https://issues.apache.org/jira/browse/HDFS-6912
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: caching
>    Affects Versions: 2.5.0
>         Environment: HDFS Data node, with 8 gb tmpfs in /dev/shm
>            Reporter: Gopal V
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-6912.001.patch, HDFS-6912.002.patch, 
> HDFS-6912.003.patch
>
>
> SharedFileDescriptor factory should not allocate sparse files.  Sparse files 
> can lead to a SIGBUS later in the short-circuit reader when we try to read 
> from the sparse file and memory is not available.
> Note that if swap is enabled, we can still get a SIGBUS even with a 
> non-sparse file, since the JVM uses MAP_NORESERVE in mmap.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to