[
https://issues.apache.org/jira/browse/HDFS-6987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141547#comment-14141547
]
Andrew Wang commented on HDFS-6987:
-----------------------------------
Thanks Zhe, getting real close now:
Nits:
* FileEncryptionInfo's constructor, the javadoc lost a line
* The new TODO, we can reference the follow-on JIRA you just filed.
getFileEncryptionInfo
* javadoc has an unclosed parens. Could also move most of the info in the
{{@return}} up to normal javadoc above the params. I try to always include a
first sentence that's short and descriptive to act as a quick summary.
* The "return null" case has changed. getEZForPath actually doesn't return null
if an EZ couldn't be found, it returns the sentinel value NULL_EZ. This
sentinel value disturbs me, so I'd like to make it simply return null and
update things to reflect this. Or we can file a follow-on for this; then we
need to update the check in getFEInfo.
More:
* We need to pass the metadata's suite from createEncryptionZone to createEZInt
to avoid calling getMetadata twice, each one is an RPC. I expect to see a call
like {{createEZInt(src, suite, keyName, cacheEntry != null}}.
> Move CipherSuite xattr information up to the encryption zone root
> -----------------------------------------------------------------
>
> Key: HDFS-6987
> URL: https://issues.apache.org/jira/browse/HDFS-6987
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: encryption
> Reporter: Andrew Wang
> Assignee: Zhe Zhang
> Attachments: HDFS-6987-20140917-v1.patch,
> HDFS-6987-20140918-v1.patch, HDFS-6987-20140919-v1.patch,
> HDFS-6987-20140919-v2.patch
>
>
> All files within a single EZ need to be encrypted with the same CipherSuite.
> Because of this, I think we can store the CipherSuite once in the EZ rather
> than on each file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
