[
https://issues.apache.org/jira/browse/HDFS-6917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145250#comment-14145250
]
Colin Patrick McCabe commented on HDFS-6917:
--------------------------------------------
bq. Can clean up the imports in DebugAdmin, I can tell where it was copy pasted
from
ok
bq. Missing some indentation in the super() calls in each command
I wanted to keep it this way so that what was shown in the source file
corresponded to what was displayed on the command-line. At the same time, I
didn't want to exceed 79 columns as per our coding standard. You can see the
dilemma here... if I use normal indentation, I either have to accept less than
79 columns for the command-line output, or exceed the limit for the source code.
bq. Need tests 
Can we do this in a follow-up?
bq. Hardcoding 7 is okay, but slightly better would be 2 +
DataChecksum.HEADER_LEN.
ok
bq. CHECKSUMS_PER_BUF seems kinda large. With 512B per checksum, we're
allocating a 64MB data buffer. I figure 8MB would be enough to still get good
disk perf.
ok
bq. metaDidRead is unused
removed
bq. Could print the current retry count when sleeping/looping
ok
bq. I expected the default # of retries to be 0, so the command by default
tries to do a single recoverLease
ok
> Add an hdfs debug command to validate blocks, call recoverlease, etc.
> ---------------------------------------------------------------------
>
> Key: HDFS-6917
> URL: https://issues.apache.org/jira/browse/HDFS-6917
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: hdfs-client
> Affects Versions: 2.6.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-6917.001.patch, HDFS-6917.002.patch
>
>
> HDFS should have a debug command which could validate HDFS block files, call
> recoverLease, and have some other functionality. These commands would be
> purely for debugging and would appear under a separate command hierarchy
> inside the hdfs command. There would be no guarantee of API stability for
> these commands and the debug submenu would not be listed by just typing the
> "hdfs" command.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
