[
https://issues.apache.org/jira/browse/HDFS-6956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147117#comment-14147117
]
stack commented on HDFS-6956:
-----------------------------
Should SpanReceiverInfoFactory be named SpanReceiverInfoBuilder?
microscopic nit: Create linkedlist once only:
+ SpanReceiver rcvr = loadInstance(className,
+ new LinkedList<ConfigurationPair>());
I love all the ways we have of doing options in hadoop (smile). I notice here
that -h won't work but should be fine since no args gives you usage.
Checks args are non-null before you put up the proxy?
No need to close proxy? There seems to be a close in protocol? Just exiting
the JVM is fine? Any chance of someone including this little script inside a
long-running app at all? If hbase wants to on/off hdfs trace, won't it need to
make use of this little client or something like it? Or I suppose these are
just admin commands... so hbase would just on/off tracing, NOT on/off tracing
sink. (IIRC stopping proxy hoses it so it can't be used again...that may be my
recollection of a childhood experience that involved me and an early hadoop...)
bq. +@InterfaceAudience.LimitedPrivate({"HDFS", "YARN"})
Does above mean who can be clients of this newly added protocol? If so, we
should had HBase since we'll be pulling on this chain for sure.
Patch looks great.
Patch is for hadoop trunk?
Does TraceAdminProtocolTranslatorPB (and other new classes in this package)
need audience annotations?
> Allow dynamically changing the tracing level in Hadoop servers
> --------------------------------------------------------------
>
> Key: HDFS-6956
> URL: https://issues.apache.org/jira/browse/HDFS-6956
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode, namenode
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HDFS-6956.002.patch, HDFS-6956.003.patch,
> HDFS-6956.004.patch
>
>
> We should allow users to dynamically change the tracing level in Hadoop
> servers. The easiest way to do this is probably to have an RPC accessible
> only to the superuser that changes tracing settings. This would allow us to
> turn on and off tracing on the NameNode, DataNode, etc. at runtime.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
