[ https://issues.apache.org/jira/browse/HDFS-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149195#comment-14149195 ]
Hudson commented on HDFS-7131: ------------------------------ SUCCESS: Integrated in Hadoop-Hdfs-trunk #1883 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1883/]) HDFS-7131. During HA upgrade, JournalNode should create a new committedTxnId file in the current directory. Contributed by Jing Zhao. (jing: rev e9c37de485f8d4dcb04afb0d4cb887cc09d317c9) * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalNode.java * hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestDFSUpgradeWithHA.java * hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/Journal.java > During HA upgrade, JournalNode should create a new committedTxnId file in the > current directory > ----------------------------------------------------------------------------------------------- > > Key: HDFS-7131 > URL: https://issues.apache.org/jira/browse/HDFS-7131 > Project: Hadoop HDFS > Issue Type: Bug > Components: qjm > Affects Versions: 2.4.0 > Reporter: Jing Zhao > Assignee: Jing Zhao > Fix For: 3.0.0, 2.6.0 > > Attachments: HDFS-7131.000.patch, HDFS-7131.001.patch > > > Currently while doing HA upgrade, we do not create a new committedTxnId file > in the new current directory of JournalNode. And before we have the fix in > HDFS-7042, since the file channel is never closed, for any new journal we're > actually updating the committedTxnId file in the previous directory. This can > cause NN to fail to start while rollback. > HDFS-7042 fixes the main part of the issue: the file channel inside of the > committedTxnId object gets closed thus later a new file can be created in the > current directory. But maybe it is still better to copy the content file > during the upgrade so that we can always use it for sanity check. -- This message was sent by Atlassian JIRA (v6.3.4#6332)