[
https://issues.apache.org/jira/browse/HDFS-7154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152169#comment-14152169
]
Colin Patrick McCabe commented on HDFS-7154:
--------------------------------------------
Please don't return "-1 " from a program. Program return codes are actually
unsigned bytes from 0 to 255 inclusive. Returning -1 shows up on the shell as
255. We normally return 1 on error and 0 on success.
> Fix returning value of starting reconfiguration task
> ----------------------------------------------------
>
> Key: HDFS-7154
> URL: https://issues.apache.org/jira/browse/HDFS-7154
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: datanode
> Affects Versions: 3.0.0, 2.6.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HDFS-7154.000.patch
>
>
> Running {{hdfs dfsadmin -reconfig ... start}} mistakenly returns {{-1}}
> (255). It is due to {{DFSAdmin#startReconfiguration()}} returns wrong exit
> code. It is expected to return 0 to indicate success.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
