[ 
https://issues.apache.org/jira/browse/HDFS-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175844#comment-14175844
 ] 

Hadoop QA commented on HDFS-7264:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12675634/h7264_20141017.patch
  against trunk revision c3de241.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.TestLeaseRecovery2
                  
org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencingWithReplication
                  org.apache.hadoop.hdfs.server.namenode.ha.TestDNFencing

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/8449//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/8449//console

This message is automatically generated.

> Tha last datanode in a pipeline should send a heartbeat when there is no 
> traffic
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-7264
>                 URL: https://issues.apache.org/jira/browse/HDFS-7264
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>         Attachments: h7264_20141017.patch
>
>
> When the client is writing slowly, the client will send a heartbeat to signal 
> that the connection is still alive.  This case works fine.
> However, when a client is writing fast but some of the datanodes in the 
> pipeline are busy, a PacketResponder may get a timeout since no ack is sent 
> from the upstream datanode.  We suggest that the last datanode in a pipeline 
> should send a heartbeat when there is no traffic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to