[ 
https://issues.apache.org/jira/browse/HDFS-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14177941#comment-14177941
 ] 

Yi Liu commented on HDFS-7243:
------------------------------

Hi Charles, I was going to commit this patch just now, but found another issue, 
sorry for missing that in previous comments.
{code}
dir.getINodesInPath4Write(target, true);
{code}
we should call
{code}
dir.getINodesInPath4Write(target);
{code}
Since the later will hold the FsDir read lock.

Besides, another small nits in the test, 
{code}
fs.concat(new Path(ez, "target"), new Path[] { src1, src2 });
{code}
We could use {{target}} instead of {{new Path(ez, "target")}} 

> HDFS concat operation should not be allowed in Encryption Zone
> --------------------------------------------------------------
>
>                 Key: HDFS-7243
>                 URL: https://issues.apache.org/jira/browse/HDFS-7243
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: encryption, namenode
>    Affects Versions: 2.6.0
>            Reporter: Yi Liu
>            Assignee: Charles Lamb
>         Attachments: HDFS-7243.001.patch, HDFS-7243.002.patch, 
> HDFS-7243.003.patch
>
>
> For HDFS encryption at rest, files in an encryption zone are using different 
> data encryption keys, so concat should be disallowed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to