[
https://issues.apache.org/jira/browse/HDFS-6291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180209#comment-14180209
]
Ted Yu commented on HDFS-6291:
------------------------------
With image.close() in finally block, the catch block doesn't need to call it,
right ?
> FSImage may be left unclosed in BootstrapStandby#doRun()
> --------------------------------------------------------
>
> Key: HDFS-6291
> URL: https://issues.apache.org/jira/browse/HDFS-6291
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: ha
> Reporter: Ted Yu
> Priority: Minor
> Attachments: HDFS-6291.patch
>
>
> At around line 203:
> {code}
> if (!checkLogsAvailableForRead(image, imageTxId, curTxId)) {
> return ERR_CODE_LOGS_UNAVAILABLE;
> }
> {code}
> If we return following the above check, image is not closed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
