Hi Nuno,
I'm trying to use Sequoia also with Spread (another group
communication toolkit, www.spread.org) and I have a problem. Spread
does not use IP addresses, the identifiers of group members are just
strings. But the hedera Member class needs an IpAddress (also hedera
class) that needs a java.io.InetAddress. This I cannot retrieve from
Spread.
My suggestion is: Since hedera should be implementable using different
solutions for group communication, can the InetAddress field of the
IpAddress class of hedera be something more generic, like (for
instance) a SocketAddress, or an interface that could be implemented
differently, depending on the toolkit used to implement hedera? Does
this have a big affect on Sequoia?
I tried to change the InetAddress field to a SocketAddress (in the
IpAddress class) and I just had to change something like 6 lines of
code in hedera. Despite that, the ChannelPerformanceTest continues to
run properly, so if Sequoia does not use the IpAddress, this change
will improve hedera, since it will be more generic.
What do you think?
This looks like an excellent suggestion. Double check that no other part
of the code requires an InetSocketAddress instead of just a
SocketAddress. SocketAddress would be better if it does not break anything.
Damian would also have to check that this works with our other
implementations but this looks pretty good.
Don't hesitate to commit the modifications,
Emmanuel
_______________________________________________
Hedera mailing list
[email protected]
https://forge.continuent.org/mailman/listinfo/hedera
