Feedback added to the gist. Trink
On Tue, Jul 7, 2015 at 12:06 PM, Rob Miller <rmil...@mozilla.com> wrote: > On 07/07/2015 11:40 AM, Ali wrote: > >> Hi, all! >> >> I'm finally done with my Lua decoder and thought I would post a link to >> it here, both for any constructive criticism anyone might have and for >> helping out anyone who was in the same situation I was in. Here's the >> link: >> >> https://gist.github.com/hourback/56e93786df14a17b14da >> > Looks quite reasonable to me. Nice work! > >> This was basically born out of the need to parse fractional seconds in >> the WebSphere systemout.log files. Go's time package doesn't recognize >> separators that aren't periods. (There's an open issue for adding >> support for commas, at least.) So I was unable to use >> PayloadRegexDecoder; I saw no way to do it other than writing a Lua >> decoder or a Go decoder. >> > Using Lua and LPeg is the recommended way to do parsing in Heka. > PayloadRegexDecoder is available for very simple cases, but it's not very > fast nor is it very flexible, and there is very little benefit to writing a > custom Go decoder. > > Thanks for sharing your code. > > -r > > _______________________________________________ > Heka mailing list > Heka@mozilla.org > https://mail.mozilla.org/listinfo/heka >
_______________________________________________ Heka mailing list Heka@mozilla.org https://mail.mozilla.org/listinfo/heka
