On 19.11.2012 20:24, Dominik Taborsky wrote: >> So who are the clients of this new functionality. Do we already have >> some of them in HelenOS? > > Not yet. But I'm (slowly) working on GPT implementation which needs it.
Let's wait with integrating this until we have a use for it. Either the GPT implementation or if we find some other code which already uses its secret clone. >> In the past, we had some licensing problems with similar functions. For >> example, we had to remove some of the ext4 checksums and hashes code >> because it was taken directly from Linux. I'd therefore like to find out >> more about the origin of this patch. Did you write it entirely yourself >> or did you use some other source also? > > I got my inspiration from other sources, but I wrote it myself. I put > two references in the code comments - one for theory, one for the > practical implementation at OSdev. But I wrote it myself (except that > CRC table, which is the same everywhere, so I doubt it needs me to > recompute the numbers myself :-) ). But this is exactly why there was a Linux implementation in our sources in the past. People just don't want to generate the table themselves so they copy it. Despite the obvious fact that the results in the table will always be the same for a given polynomial, this is technically still copying of third party code. The only option is therefore to either generate the results ourselves or give appropriate credit to the original source from which the table came from (if it has a compatible license). > That would be a nice solution. The ticket mentions it could be in a > standalone library OR libc itself. > > I can make a new library if we can agree on it, but I won't be adding > other CRC implementations. I just need this one and then I have enough > of other work in HelenOS... :-) > > So just let me know - is this patch enough, or should I make a > completely new library and possibly make a whole new branch? For now, it is probably enough. But as I said, we need to have a user of that new code. Plus the issue with using someone else's table. Jakub _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/cgi-bin/listinfo/helenos-devel
