Hi Maurizio,
feel free to do it. Currently although locsrv creates the bd category, there
is no block device driver that would use it - DDF or non-DDF (and there is
no consumer which would search that category, except for a human). I am
aware that changing ata_bd to DDF means that the service name is now less
human friendly/less obvious. USB mass storage driver is in the same
situation. SATA is wierdly implemented as a DDF/non-DDF driver combo (I am
planning to look into that, just currently I can't get the driver to work at
all), the rest of the drivers are AFAIR non-DDF but they could be made to do
the same, just so the user has a single way of looking up all their block
devices (loc show-cat bd).
Best regards,
Jiri
---------- Původní zpráva ----------
Od: Maurizio Lombardi <[email protected]>
Datum: 12. 7. 2013
Předmět: [HelenOS-devel] ata_bd problem
"Hi Jiri,
I noticed you reimplemented the ata_bd server as a DDF driver.
There is a little problem: the ata_bd driver successfully detects the
drives but does add the functions to the appropriate "bd" category.
Is it a problem you are already aware of? I wrote the following patch to fix
it:
=== modified file 'uspace/drv/block/ata_bd/main.c'
--- uspace/drv/block/ata_bd/main.c 2013-06-27 20:43:29 +0000
+++ uspace/drv/block/ata_bd/main.c 2013-07-12 06:51:29 +0000
@@ -197,6 +197,8 @@
goto error;
}
+ ddf_fun_add_to_category(fun, "bd");
+
free(fun_name);
disk->afun = afun;
return EOK;
--
--------------------
Maurizio Lombardi"
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
