On Wed, 30 Oct 2013 11:16:34 +0100, Martin Decky wrote:
Hello Jakub,
thanks for your report and also for the previous reports. Your
progress seems to be well within the timeline, but please make sure
that you don't lose your momentum -- there is a week-long gap in the
LaunchPad history. I am far from pushing, you can surely afford the
short hiatus, this is just a friendly preemptive reminder to avoid a
long hiatus :)
Well, I was not doing commits often, as the code on I was working on
was (and still it) work in progress. But you are right, I'll arrange
this week work to make frequent smaller commits.
* Written test code to verify trap handlers work
Do you intent do keep this test in the source tree or it is there
just to help your development process and will be removed eventually?
If the former is true, I suggest you move it to the kernel/test
infrastructure and clean it up a little bit.
I think that this code will be removed, as it's not usable outside
debugger.
I have glanced quickly through the sources. Nothing major to report,
I understand that it is a work in progress and you'll fix some small
coding style issues eventually. I have only one note regarding the
various debugging printouts: You don't necessarily have to remove
them
all during a later code clean up, you can convert some of them to
LOG() calls as they might be handy in the future.
Thank for pointing this out - I'll investigate LOG() functions.
Regards,
Jakub
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
