Hello Sebastian,
thank you for your contribution. I'll review your German keyboard layout
later today.
I have also examined your kernel framebuffer pager. If I should comment
on your code, you have missed a few coding style guidelines [1] (esp.
regarding parentheses), but otherwise the code looks reasonable. The
idea to use the backbuffer as a ring buffer (instead of copying the
contents on scrolling) is definitively worth it.
However, I have decided not to merge your patch as is in the end. I have
reimplemented the pager from scratch. My main motivation was to
introduce out-of-band signalling from the input driver that triggers the
scrolling instead of passing the Page Up and Page Down characters to the
output device in-band. This allows for scrolling even if the kernel
console thread is not popping characters from the input device.
Anyway, thanks again for your input!
[1] http://trac.helenos.org/wiki/CStyle
M.D.
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
