On Sat, 28 Jun 2014 11:41:48 +0200 Maurizio Lombardi <[email protected]> wrote: > > > > Otherwise the patch looks good to me except cstyle - the double > > underscores in __block_get_nblocks - I think __ prefix should be > > used only for compiler symbols and the function is static anyway, > > so it is not necessary. > > This is just because there is already a function with the same name, > but I needed it to accept different parameters, so I modified the code > in the following way: > > int block_get_nblocks(service_id_t service_id, aoff64_t *nblocks) > { > devcon_t *devcon = devcon_search(service_id); > assert(devcon); > > return __block_get_nblocks(devcon->bd, nblocks); > } > > /** Get number of blocks on device **/ > static int __block_get_nblocks(bd_t *bd, aoff64_t *nblocks) > { > return bd_get_num_blocks(bd, nblocks); > } OK, in that case I suggest something like block_get_nblocks_internal instead of __block_get_nblocks.
Regards, Martin Sucha _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
