Hello. 2017-03-21 6:39 GMT+01:00 punk joker <[email protected]>:
> For newsletter subscribe, answers do not come. Try to use a different > email address. > Would you provide a bit more information here, please? > Now in the case. To begin, I decided to just change the buffer to the new > window size, if necessary, ejecting the superfluous data. In this approach, > the increase in the working window. But decreasing when the window size > becomes less than the current position, the program crashes. Most likely > there is an attempt to withdraw the data or to set the cursor beyond the > boundaries of the buffer. But unfortunately, I can't find the problem. > Edited these files: > /home/joker/HelenOS/mainline/uspace/lib/c/generic/io/chargrid.c > /home/joker/HelenOS/mainline/uspace/lib/gui/terminal.c > Modified files attached to the letter. > Thanks for the files. I have looked at your modifications and I have a few comments/questions. First of all, it is much better if you send your changes as a patch that can be applied rather than modified files only. For example, I assume you also changed uspace/app/vterm/vterm.c adding the WINDOW_RESIZEABLE flag. Now, to the changes. The chargrid_destroy is a little bit more complicated than your solution. If you look in chargrid_create, the memory might also come from as_area_create ... Your patch discards cursor position. When the window is being enlarged I would expect that the position could be kept the same. Would it be possible to fix that? Regarding the crash: I suspect there is some off-by-one problem because when resizing the window (horizontally only) it often jumped by one line up. And one more thing: I think the flags to chargrid_resize_new() are superfluous as the flags shall be copied from the old chargrid. Cheers, - Vojtech > > _______________________________________________ > HelenOS-devel mailing list > [email protected] > http://lists.modry.cz/listinfo/helenos-devel > >
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
