Hi Supragya Raj,

On 03/24/2017 04:27 PM, Supragya Raj wrote:
> Thanks for looking into my patch, I do realize comparison with int and
> long were not correct in the patch. I have corrected this, in this
> patch. You may find the same as attachment.

Thanks.

> Any further feedbacks?

Yes :-)

The patch is big and cluttered with many whitespace changes that are not
related to the actual fix. I assume these were done automatically by
your editor in a good faith. Could you please switch this feature off
and regenerate the patch once more so that it _only_ contains your fix?
Note that you can verify whether the patch looks good simply by opening
it in a text editor or, even better, by cat'ing it to your terminal.

Best,
Jakub

_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to