Hi Ashish,
thanks for sending us your patch. Please see my comments inline.
On 03/31/2017 05:26 AM, Ashish Gahlot wrote:
> === modified file 'uspace/lib/clui/tinput.c'
> --- uspace/lib/clui/tinput.c 2015-10-20 10:08:15 +0000
> +++ uspace/lib/clui/tinput.c 2017-03-31 03:20:32 +0000
> @@ -31,9 +31,11 @@
> #include <stdlib.h>
> #include <str.h>
> #include <io/console.h>
> +#include <io/con_srv.h>
Why are you including io/con_srv.h?
> #include <io/keycode.h>
> #include <io/style.h>
> #include <io/color.h>
> +#include <io/output.h>
Why are you including io/output.h?
> #include <vfs/vfs.h>
> #include <clipboard.h>
> #include <macros.h>
> @@ -41,11 +43,13 @@
> #include <assert.h>
> #include <stdbool.h>
> #include <tinput.h>
> +#include <task.h>
Why are you including task.h?
>
> #define LIN_TO_COL(ti, lpos) ((lpos) % ((ti)->con_cols))
> #define LIN_TO_ROW(ti, lpos) ((lpos) / ((ti)->con_cols))
> #define LIN_POS(ti, col, row) ((col) + (row) * (ti)->con_cols)
>
> +
There is also some whitespace noise in your patch.
> /** Seek direction */
> typedef enum {
> seek_backward = -1,
> @@ -950,12 +954,16 @@
> tinput_sel_delete(ti);
> break;
> case KC_C:
> - tinput_sel_copy_to_cb(ti);
> + tinput_sel_copy_to_cb(ti);
More noise here.
The patch clears the screen, but does not move the cursor to the
beginning of it, which feels strange. Anyway, please try to polish your
patch a little bit and re-submit.
Thanks,
Jakub
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
