Hi Jan, On 04/03/2017 03:25 AM, Jan Vesely wrote: > On Thu, 2017-03-30 at 08:37 +0200, Jakub Jermář wrote: >> On 03/30/2017 04:51 AM, Supragya Raj wrote: >>> In the given patch, I have changed a few things as Jakub advised, >>> changing uint32_t and uint64_t to int32_t and int64_t. >> >> I've just applied your patch in mainline,2586. Thanks for contributing this! > > the patch looks wrong. all three instances are missing break statement. > Thus the qualifier will always be 'PrintfQualifierShort'.
Good catch! Btw, when one adds the missing breaks, one also needs to add the missing decoding of the next character. Mea culpa - I thought those were not needed as the tests were passing and I clearly overlooked the breaks :-) > The test won't catch this, because it only tests small difference that > fits into the first two bytes (on LE machines). Has anyone run the test > on a BE machine? I actually did test it on ppc32, among others, but it didn't help me spot this. I attempted to fix this in mainline,2587. Thanks for watching! Jakub _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
