On 16 May 2018 at 14:42, Jiri Svoboda <[email protected]> wrote: > Hi Jzr et al, > > I've implemented checking of block comment formatting in Ccheck. Now for > source files that contain CZ.NIC copyright + Authors: comment I get a > suggested fix such as: > > --- a/abi/include/_bits/NULL.h > +++ b/abi/include/_bits/NULL.h > @@ -26,7 +26,8 @@ > * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > */ > > -/* Authors: > +/* > + * Authors: > * Jiří Zárevúcky (jzr) <[email protected]> > */ > > Since currently Authors text is on the same line as '/*' but I'd like this > to be forbidden and fixed as seen above. This is following the general > practice that is mostly observed in HelenOS source. Do you have any concerns > (e.g. legal)? I think it should be okay since it's a cosmetic change, but I > just want to make sure. >
My concern is purely stylistic. IMO, putting /* on a separate line is a waste of screen space, as is the trailing */. I would vastly prefer switching to C++-style comments. But since that's not the issue being raised here, feel free to go ahead with the fix. -- jzr _______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
