Hi Jzr,
I agree with you. I just didn't give it enough time to be sure enough that
there wasn't some legitimate reason why you'd get a non-zero return code
that should be ignored. I looked at it again and I agree that the value
should be checked (with an assert). I did that and everything exploded :-D
Found out that, actually, async_hangup() closes the same phone twice for
EXCHANGE_ATOMIC or EXCHANGE_SERIALIZE. See http://www.helenos.org/ticket/819
Cheers,
Jiri
---------- Původní e-mail ----------
Od: Jiří Zárevúcky <[email protected]>
Komu: HelenOS/helenos <[email protected]>
Datum: 5. 5. 2020 19:25:15
Předmět: Re: [HelenOS/helenos] async_hangup() should just always succeed
(622e7c9)
"
I agree that this should not fail, and it would be even better if failure in
ipc_hangup() wasn't just silently ignored. If there is a bug somewhere
causing this to return error, I'd expect the program to be very loud about
it and terminate. It would make debugging easier if that ever happens.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
(https://github.com/HelenOS/helenos/commit/622e7c90371690351474d65883d372074a6be553#commitcomment-38961751)
, or unsubscribe
(https://github.com/notifications/unsubscribe-auth/ABM5KZTDOEL6ZREOMNVGMVDRQBDXNANCNFSM4MZYLWYA)
.
"
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel
