Hi Manuel,
thanks for sending your change. Libdraw does not have a bright an shiny
future so I'm not sure if it's worth spending effort in adding features to
it. In the future graphic primitives will be provided by libgfx. I am now
working on libgfxfont to provide proportional font capability, after that my
plan is to simultaneously work on new GUI library which will be based on
libgfx and adding graphic primitives to libgfx.
Once libgui is supplanted by this new GUI library and is removed, libdraw
will be removed as well.
Having said that I'm not sure how deep it makes sense to go into your
changes, but I did note some stylistic issues:
- _x, _y - names beginning with underscores should not be used for local
variables
- { statement; statement } .. the body of a block should be on a separate
line. Each statement should be on a separate line. Did this pass ccheck? I
think it should not..
- int dx = abs(xe - xs), sx = xs < xe ? 1 : -1; - these should be separate
statemetns on separate lines. I don't think I've ever used comma operator in
normal code. There are some cases where it would be tolerable, but this is
not it.
Apart from that I would have some questions more on the functional level,
but probably not worth going into given the circumstances.
Cheers,
Jiri
---------- Původní e-mail ----------
Od: Manuele Conti <manuele.co...@archimede-energia.com>
Komu: helenos-devel@lists.modry.cz <helenos-devel@lists.modry.cz>
Datum: 2. 8. 2020 1:11:22
Předmět: [HelenOS-devel] Add drawctx_stroke implementation
"
Hi All,
I try to add by myself drawctx_stroke function. This stroke implementation
strokes the shape using a thin line.
You can find my code at link below:
https://github.com/manux81/helenos-1/tree/add_draw_stroke
(https://link.getmailspring.com/link/8fc93b0a-d553-4ec0-b6a2-00c3c3422...@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2Fmanux81%2Fhelenos-1%2Ftree%2Fadd_draw_stroke&recipient=aGVsZW5vcy1kZXZlbEBsaXN0cy5tb2RyeS5jeg%3D%3D)
What suggestions do you have?
Best regards,
Manuele
Sent from Mailspring _______________________________________________
HelenOS-devel mailing list
HelenOS-devel@lists.modry.cz
http://lists.modry.cz/listinfo/helenos-devel
"_______________________________________________
HelenOS-devel mailing list
HelenOS-devel@lists.modry.cz
http://lists.modry.cz/listinfo/helenos-devel
