Good point, should I close the PR and raise an issue instead?

Edward

On Sat, Mar 27, 2021, 11:43 AM Jiri Svoboda <[email protected]> wrote:

> Forgot to include helenos-devel, which somehow fell out of the loop.
> -Jiri
>
> ---------- Původní e-mail ----------
> Od: Jiri Svoboda <[email protected]>
> Komu: GameDevFox <[email protected]>
> Datum: 27. 3. 2021 17:42:37
> Předmět: Re: Reply to Raspberry Pi query on IRC
>
> Hi Ed,
>
> I don't think forcing old version of meson is the best approach, except
> for the improbable case that this is actually a bug in meson itself. It
> rather looks to me like there is some bug in our build files, or at least
> some construction that has been made obsolete or changed its behavior. We
> need to track that down and probably fix our build files.
>
> Cheers,
> Jiri
> ---------- Původní e-mail ----------
> Od: GameDevFox <[email protected]>
> Komu: Jiri Svoboda <[email protected]>
> Datum: 27. 3. 2021 16:42:51
> Předmět: Re: Reply to Raspberry Pi query on IRC
>
> Hey Jiri,
>
> Thanks for the quick reply.
>
> I found out the reason why my ninja build was failing. It turns out that
> when I ran pip3 install meson it installed version 0.57.1 (the latest)
> which would create a ninja build that would fail.
>
> When I uninstalled meson 0.57.1 and reinstalled version 0.50.1 (the
> version that gets installed in the .travis.yml build script) and ninja
> build succeeds!
>
> I created a pull request that updates the README.md to include this detail
> in the pip3 examples. If there are any changes or additions you'd like me
> to make to this PR please let me know.
> https://github.com/HelenOS/helenos/pull/210
>
> Thanks again,
> Edward
>
> On Sat, Mar 27, 2021, 5:16 AM Jiri Svoboda <[email protected]>
> wrote:
>
> Hi GameDevFox,
>
> following up to your query on IRC:
> <GameDevFox> Hi everyone. Is there anyone willing to help me figure out
> why my `arm32/raspberrypi` build is failing when I run `ninja` in my
> helenos build directory?
> <GameDevFox> A lot of warnings are shown in the logs and the compiler
> seems to be treating the warnings as errors, complaining about "ISO C
> standards"
> <GameDevFox> If anyone would like to connect, please email me at
> [email protected]
>
> Please make sure you are using the correct version of the toolchain built
> via up-to-date version of tools/toolchain.sh (i.e. version from master).
> The most likely reason is that you are using a different version of gcc
> which presents different warnings.
>
> [jirka@omelette win31]$ /usr/local/cross/bin/arm-helenos-gcc --version
> arm-helenos-gcc (GCC) 8.2.0
> Copyright (C) 2018 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> If you have the correct toolchain there should be no warnings. It is
> possible to prevent gcc turning warnings to errors, which can be done
> either by configuring a non-debug build or removing the lines
>
> if CONFIG_DEBUG
>         extra_common_flags += [ '-Werror' ]
> endif
>
> from meson/part/compiler_args/meson.build
> But I would consider that only as a last-resort solution.
>
> Best regards,
> Jiri
>
>
_______________________________________________
HelenOS-devel mailing list
[email protected]
http://lists.modry.cz/listinfo/helenos-devel

Reply via email to