On Mon, Feb 13, 2023, 12:21 AM Martin Decky <[email protected]> wrote: > > That said, I'm in the process of changing the context switching code > > so that most of the structure becomes unnecessary. > > All that's really needed in context_t is IP, SP and possibly an > > argument field if we want to be fancy about new context > > initialization. > > OK, fair enough. Looking forward to your future changes! > > Having said that, if this particular change is more-or-less just a > preparation for future intended changes, it would be nice if this could > be mentioned in the commit message. Ideally with some slightly verbose > general reasoning. >
It isn't. It's just a result of me seeing a global variable (or close enough to it) being used where a local one is sufficient. I just didn't consider that the stack could be really small compared to the context size, which is why I'm happy you're paying attention. I do try to make sure each of my commits makes sense in isolation. The realization that contexts can be made smaller came later. > [...] > > I've seen many commits to HelenOS in the past few years with very brief > commit messages and zero rationale or explanation (but sometimes even > with some questionable comedic aspiration) and I am not happy about it. > > [...] > I'm sure I'm guilty of a fair share of those. The rationale usually boils down to "the code doesn't feel right, and I'm trying to make it more elegant". I'll try to do better in the future. -- J. Z.
_______________________________________________ HelenOS-devel mailing list [email protected] http://lists.modry.cz/listinfo/helenos-devel
