>> By the way: The code uses
>> "(declare (special ...))" to mark these cases and to pacify the
>> byte-compiler. Someone with CVS write access could replace these with an
>> equivalent non-CL statement, i.e., append the named variables to
>> "byte-compile-bound-variables".
> No, those declarations are there to pacify the Common Lisp cravings of
> the author. The right thing to do is to defvar the global variables at
> the top level (either in url-http.el itself or in one of the libraries
> it requires).
There's nothing wrong with (declare (special ...) ...).
>>> But (append (list x) ...) is better expressed as (cons x ...):
>>>
>>> (cons redirect-uri (cdr url-callback-arguments))
>>
>> Isn't that a matter of taste? I find it more intuitive to use "append"
>> and "list" for list operations and "cons" for simple cells. But I am no
>> lisp expert.
It's just a lot less efficient.
Stefan
_______________________________________________
Help-gnu-emacs mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/help-gnu-emacs
