Alex Kost writes:

> Jan Nieuwenhuizen (2018-09-13 22:45 +0200) wrote:
>
>> (defun guix-switch-profile (&optional profile)

> Thank you!  I'm going to apply it.  I have extracted the guile code and
> put it to the "scheme side" of Emacs-Guix, also I have rewritten this
> command a bit.  The only thing: I don't like the name (neither
> "guix-switch-profile" nor "guix-profile-apply").  I think
> "guix-set-emacs-environment" suits better, as setting the environment is
> exactly what this command does, WDYT?

> You may look at my version of your patch (not in "master" yet) here:
>
>   
> https://notabug.org/alezost/emacs-guix/commit/a4bd696f0b8c564c1e654c426e9059cac1607996

Thank you, I enjoyed reading your rewrite, makes me happy!  Moving the
scheme side makes it cleaner and I learned about -let, nice :-)

I also like the new name better, you see that I struggled/renaed because
I wasn't happy with it.  The initial switch-profile name was simply
chosen because that's how I use it: to switch between my named profiles.

> Let me know, if you think something should be fixed there.

I think it's OK to go in.  The thing I'm not really happy with yet is
the UX of how to switch to temporary `guix environment ...'
environments.  You have to do: echo $GUIX_ENVIRONMENT, <select>, <cut>,
M-x guix-set-emacs-environment RET <paste> ... but I have no idea how we
could improve on that.  Thoughts?

janneke

-- 
Jan Nieuwenhuizen <jann...@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com

Reply via email to