Package: libidn
Version: 1.28-1
Followup-For: Bug #719980

I found that libidn does not implement DEB_BUILD_OPTIONS=nocheck to skip tests.

The attached patch fixes that. I didn't open a new bug as this is just a
subset of the patch already filed in this bug. (almost identical for that part, 
in fact :-)

I too noticed this problem whilst bootstrapping (arm64). The tests make
qemu arm64 crash, so must be skipped to get a successful build.

Just another example of why this is useful.

-- System Information:
Debian Release: 7.2
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-kvm-i386-20110111 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru libidn-1.28/debian/changelog libidn-1.28/debian/changelog
--- libidn-1.28/debian/changelog	2013-07-10 08:32:46.000000000 +0000
+++ libidn-1.28/debian/changelog	2013-11-10 23:52:33.000000000 +0000
@@ -1,3 +1,9 @@
+libidn (1.28-1~nocheck) unstable; urgency=low
+
+  * Respect 'nocheck' DEB_BUILD_OPTION
+
+ -- Wookey <[email protected]>  Sun, 10 Nov 2013 23:51:21 +0000
+
 libidn (1.28-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru libidn-1.28/debian/rules libidn-1.28/debian/rules
--- libidn-1.28/debian/rules	2013-07-10 13:31:48.000000000 +0000
+++ libidn-1.28/debian/rules	2013-11-10 23:50:27.000000000 +0000
@@ -12,6 +12,13 @@
   export DH_OPTIONS=-Nlibidn11-java
 endif
 
+# Don't run tests if DEB_BUILD_OPTIONS includes nocheck
+ifeq (,$(filter $(DEB_BUILD_OPTIONS),nocheck))
+  TESTS = check 
+else
+  TESTS =
+endif 
+
 # These are used for cross-compiling and for saving the configure script
 # from having to guess our platform (since we know it already)
 DEB_HOST_GNU_TYPE   ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
@@ -43,7 +50,7 @@
 	dh_testdir
 
 	# Add here commands to compile the package.
-	$(MAKE) all check
+	$(MAKE) all $(TESTS)
 
 	touch $@
 
_______________________________________________
Help-libidn mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/help-libidn

Reply via email to